This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.09] backport default-addr-pool-mask-length param max value check#73
Merged
tiborvass merged 2 commits intodocker-archive:18.09from Oct 11, 2018
Merged
Conversation
Addressing few review comments as part of code refactoring. Also moved validation logic from CLI to Moby. Signed-off-by: selansen <elango.siva@docker.com> (cherry picked from commit 148ff00) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
We check for max value for -default-addr-pool-mask-length param as 32. But There won't be enough addresses on the overlay network. Hence we are keeping it 29 so that we would be having atleast 8 addresses in /29 network. Signed-off-by: selansen <elango.siva@docker.com> (cherry picked from commit d25c5df) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @selansen PTAL |
|
Little confused here. half of moby#37736 changes already in due to #60 but few changes are missing. |
|
LGTM |
Member
Author
|
yes it would've been easier if #60 cherry-picked the upstream changes, but it was merged already, so I decided to just fix the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of moby#37736 and moby#37949 for 18.09
conflict in daemon/cluster/noderunner.go and vendor.conf, due to #60, which is not in upstream