`strip --strip-all` must be conditional when php was (re)compiled with `--enable-debug`

[mvorisek]

This is a feature request.

php/8.1/bullseye/cli/docker-php-ext-install

Lines 108 to 113 in b3e6173

	find modules \
	-maxdepth 1 \
	-name '*.so' \
	-exec sh -euxc ' \
	strip --strip-all "$@" || :
	' -- '{}' +

should be wrapped in a condition to check if php was configured /wo debug mode

for debug mode, no symbols should be stripped

as a temporary solution sed -zE 's~[^\n]+find modules[^\n]+\n[^\n]+-maxdepth[^\n]+\n[^\n]+-name[^\n]+\n[^\n]+-exec[^\n]+\n[^\n]+strip --strip-all[^\n]+\n[^\n]+\{\}[^\n]+\n~~' can be used, but native support/condition is highly appreciated

[tianon]

I think I'm a little confused -- all our PHP builds are without debug symbols / stripped?

php/Dockerfile-linux.template

Lines 399 to 406 in 399ed12

	find \
	/usr/local \
	-type f \
	-perm '/0111' \
	-exec sh -euxc ' \
	strip --strip-all "$@" || : \
	' -- '{}' + \
	; \

(This block of code in the template doesn't have any if around it -- it is included in all variants.)

[mvorisek]

That is correct - debug build is never enabled, but if php is recompiled manually with debug enabled, the docker-php-ext-install script should honor that and do NOT strip any symbols

[tianon]

Hmm, is there a clean way we can reliably detect that? That's not really a configuration we officially support, so I hesitate to make our already somewhat complex script even more complex unless the implementation is really clean/straightforward. 😅

Is there maybe a way we can query it from PHP itself? I don't really like the idea of just "guessing" based on whether something like /usr/local/bin/php still has any debugging symbols. 🙈

[mvorisek]

Hmm, is there a clean way we can reliably detect that? Is there maybe a way we can query it from PHP itself?

Yes, there is php constant for it, together with -n option for php binary to skip any ini configuration, we can query it reliably with the following command:

php -n -r 'echo ZEND_DEBUG_BUILD;'

[tianon]

Oh, nice! I'll get around to it eventually if you don't, but if you have a debug build already handy, can you share the output of that on it? 😇

[mvorisek]

https://github.com/mvorisek/image-php/runs/5680159626?check_suite_focus=true#step:5:65

for php compiled with --enable-debug, the value is 1

[tianon]

Very nice, thank you! PR filed at #1278 👍

[mvorisek]

Thank you as well! PR tested, it works fabulously 👌