Make "strip" in "docker-php-ext-install" conditional on "ZEND_DEBUG_BUILD" #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
commented
Mar 24, 2022
| strip --strip-all "$@" || : | ||
| ' -- '{}' + | ||
|
|
||
| if ! php -n -d 'display_errors=stderr' -r 'exit(ZEND_DEBUG_BUILD ? 0 : 1);' > /dev/null; then |
Member
Author
There was a problem hiding this comment.
For the avoidance of doubt:
$ docker run --pull=always --rm php bash -c "if ! php -n -d 'display_errors=stderr' -r 'exit(ZEND_DEBUG_BUILD ? 0 : 1);' > /dev/null; then echo yay tianon got the logic correct; fi"
latest: Pulling from library/php
Digest: sha256:732e90365bc098199c252a05a320a63ceb077474728ec9eb3dc6cda2490463bc
Status: Image is up to date for php:latest
yay tianon got the logic correct
mvorisek
reviewed
Mar 24, 2022
…UILD" Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
tianon
force-pushed
the
conditional-strip
branch
from
60a3cd6 to
af4cd1a
Compare
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 25, 2022
Changes: - docker-library/php@9ebf005: Merge pull request docker-library/php#1278 from infosiftr/conditional-strip - docker-library/php@af4cd1a: Make "strip" in "docker-php-ext-install" conditional on "ZEND_DEBUG_BUILD"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1268