Enhanced driver guides #1233
Merged
Enhanced driver guides #1233
+138
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
reviewed
Jul 25, 2022
crazy-max
reviewed
Jul 25, 2022
crazy-max
reviewed
Jul 26, 2022
tonistiigi
reviewed
Jul 28, 2022
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
This can be follow-up but if we have guides for specific drivers I think they should cover the specific driver-opt that they take or at least link to the correct place.
Collaborator
Author
From @crazy-max earlier:
Once we do a release, and all of our docs guides+references can be taken from the release branch, we can link properly :) |
Create a dedicated folder for information on drivers, and write a new index.md with content adapted from the README, and a new feature comparisons table. Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
tonistiigi
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new basic docker-container guide to match with the existing remote and kubernetes guides. Because this is a smaller and simpler driver, the guide is as well 🎉
Additionally, to improve organization, all the driver guides are moved to a dedicated folder, with an index file to describe the high of all the drivers, pulling out existing content from the README, and introducing a new feature comparison table (not sure if I'm missing any essential features?).
Also, I've added a little bit of further reading at the end of each guide to point back to the driver opts in the buildx build reference.