-
Notifications
You must be signed in to change notification settings - Fork 8.1k
build: add drivers guides #15262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add drivers guides #15262
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -0,0 +1,20 @@ | |||
| --- | |||
| title: "Remote driver" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the note at the beginning noting this as a pre-release feature - but I think we should definitely try and make sure we don't do this a lot.
Could we maybe consider just dropping this page for now? Although, I'm not sure how we'd modify the index to drop it from the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can drop it, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh if we drop this page, the index.md is not aligned 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it for now, I will change the info note to a warning one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, it should get resolved quite soon, in the next bulidx release.
b8d90b4 to
17e6aa0
Compare
_data/toc.yaml
Outdated
| - path: /build/buildx/multiple-builders/ | ||
| title: Using multiple builders | ||
| - path: /build/buildx/multiplatform-images/ | ||
| - path: /build/buildx/multi-platform-images/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-platform images in the title and content sounds good, but I think it helps to avoid adding an extra - in the filename. This can be clunky in the URLs and when adding xrefs from other topics. Suggest we keep this as multiplatfform-images.md in the filenames.
build/buildx/drivers/remote.md
Outdated
| line_end: -1 | ||
| --- | ||
|
|
||
| > Technical preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical preview
Remote driver is currently available as a Technical Preview.
You can build a remote driver from the upstream Buildx repository{: target="blank" rel="noopener" class=""} or use
the following command to download and install an edge release of Buildx:
build/buildx/drivers/remote.md
Outdated
| line_end: -1 | ||
| --- | ||
|
|
||
| > Technical preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, should this be Beta and not Technical Preview so we are consistent with our terminology? See https://deploy-preview-14950--docsdocker.netlify.app/release-lifecycle/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the statement, "Can be discontinued without notice" I'm not sure this is the case for the remote driver as this will still be released but not yet available.
I think we could also have "Technical preview" in this page if it makes sense:
Technical preview means a service or software that is under active development and in stages of testing. Its purpose is to establish a feedback loop, allowing customers to influence its development and direction.
But in the meantime I will use Beta terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, generally, we should avoid forward-looking statements in Docs. I guess we can tag it as Beta for now and update this page to remove the Beta flag when the remote drivers feature goes GA.
1708a4c to
0c56871
Compare
0c56871 to
83b25dc
Compare
|
@usha-mandya thanks for the review. Let me know if it LGTY now. |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
83b25dc to
a20e14b
Compare
usha-mandya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
follow-up docker/buildx#1233
also fixed a broken link from upstream repo (buildx).
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com