Bump kube dependency to 1.11.0, and update other deps#1230
Bump kube dependency to 1.11.0, and update other deps#1230thaJeztah merged 3 commits intodocker:masterfrom
Conversation
vdemeester
commented
Jul 25, 2018
vdemeester
commented
- Bump kubernetes dependencies to 1.11
- Bump some dependencies to more recent versions (and tagged if available)
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
update-k8s-and-other-deps
branch
from
1c2d80a to
7df9e41
Compare
Codecov Report
@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
+ Coverage 54.23% 54.25% +0.01%
==========================================
Files 268 268
Lines 17805 17799 -6
==========================================
Hits 9656 9656
+ Misses 7542 7536 -6
Partials 607 607 |
vendor.conf
Outdated
| github.com/containerd/console cb7008ab3d8359b78c5f464cb7cf160107ad5925 | ||
| github.com/tonistiigi/units 29de085e9400559bd68aea2e7bc21566e7b8281d | ||
| github.com/google/shlex 6f45313302b9c56850fc17f99e40caebce98c716 | ||
| github.com/google/shlex 6f45313302b9c56850fc17f99e40caebce98c716 No newline at end of file |
vendor.conf
Outdated
| github.com/containerd/containerd 08f7ee9828af1783dc98cc5cc1739e915697c667 | ||
| github.com/containerd/continuity d8fb8589b0e8e85b8c8bbaa8840226d0dfeb7371 | ||
| github.com/coreos/etcd v3.2.1 | ||
| github.com/coreos/etcd v3.3.8 |
There was a problem hiding this comment.
3.3.9 was released
Also; I've been punting on this one (SwarmKit is also on a very old version, but I think there were some complications there updating, but should check)
vendor.conf
Outdated
| github.com/googleapis/gnostic 7c663266750e7d82587642f65e60bc4083f1f84e # v0.2.0 | ||
| github.com/gorilla/context v1.1.1 | ||
| github.com/gorilla/mux v1.6.2 | ||
| gotest.tools v2.1.0 |
There was a problem hiding this comment.
we should make this list alphabetical again 😅
There was a problem hiding this comment.
yeah, I think I'm gonna do a commit that reorders them 😉
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
update-k8s-and-other-deps
branch
from
7df9e41 to
cd5ed18
Compare
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
Use the tag instead of the sha.
| github.com/coreos/etcd v3.3.9 | ||
| github.com/cpuguy83/go-md2man v1.0.8 | ||
| github.com/davecgh/go-spew 346938d642f2ec3594ed81d874461961cd0faa76 | ||
| github.com/davecgh/go-spew 346938d642f2ec3594ed81d874461961cd0faa76 # v1.1.0 |
There was a problem hiding this comment.
Why not using the tag directly?
There was a problem hiding this comment.
Ah! Yes, there's been many discussions about those. Ideally, there'd be a way to specify both tag and commit/sha;
reason to use a tag:
- it's human-readable
- it's a release done by the upstream dependency
reason to not use a tag:
- we've had upstreams re-tagging (discovered when
vendor checkfailed and no changes were made in the vendor.conf) - we've had cases where it turned out not to be a tag but a branch named
v1.0(but we thought it was a tag), then found out about that (again) whenvendor checkfailed. - a commit-sha is unique, and can never change
So... how to get the best of both worlds?
- use sha
- leave comment what version it should match with?
It's tricky; because we also have to verify that the commit matches the tag 😞 possibly the git describe notation would be an option, e.g.;
v0.2.0-7-g1817cd4
- 7 commits since
v0.2.0 - sha is
1817cd4
not sure if that actually verifies if they match though? 🤔
There was a problem hiding this comment.
Oh right, lot's of issues I wasn't aware of 😓 Then that's ok for me 😸
vendor.conf
Outdated
| k8s.io/client-go kubernetes-1.11.0 | ||
| k8s.io/kube-openapi d8ea2fe547a448256204cfc68dfee7b26c720acb | ||
| k8s.io/kubernetes v1.11.0 | ||
| vbom.ml/util 256737ac55c46798123f754ab7d2c784e2c71783 No newline at end of file |
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
update-k8s-and-other-deps
branch
from
cd5ed18 to
fffec04
Compare
thaJeztah
changed the title
thaJeztah
changed the title
6 participants
