Bump a bunch of dependencies to more recent versions#37522
Bump a bunch of dependencies to more recent versions#37522vdemeester merged 1 commit intomoby:masterfrom
Conversation
|
Looks legit: |
|
@cpuguy83 yep 😓 gonna look at it 😅 |
6106c15 to
9d544ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #37522 +/- ##
=========================================
Coverage ? 35.61%
=========================================
Files ? 610
Lines ? 44905
Branches ? 0
=========================================
Hits ? 15992
Misses ? 26707
Partials ? 2206 |
|
Alright, remove |
|
good job! 🤞 |
|
@thaJeztah @vdemeester it seems like the failure isn't related: 13:42:24 FAIL: docker_api_swarm_service_test.go:311: DockerSwarmSuite.TestAPISwarmServicesFailedUpdate
13:42:24
13:42:24 [d238601374b28] waiting for daemon to start
13:42:24 [d238601374b28] daemon started
13:42:24
13:42:24 [d7b665da69c27] waiting for daemon to start
13:42:24 [d7b665da69c27] daemon started
13:42:24
13:42:24 [d768e59ef6e25] waiting for daemon to start
13:42:24 [d768e59ef6e25] daemon started
13:42:24
13:42:24 docker_api_swarm_service_test.go:347:
13:42:24 waitAndAssert(c, defaultReconciliationTimeout, daemons[0].CheckRunningTaskImages, checker.DeepEquals,
13:42:24 map[string]int{image1: instances})
13:42:24 docker_utils_test.go:435:
13:42:24 c.Assert(v, checker, args...)
13:42:24 ... obtained map[string]int = map[string]int{"busybox:latest":4}
13:42:24 ... expected map[string]int = map[string]int{"busybox:latest":5}
13:42:24
13:42:24 [d238601374b28] exiting daemon
13:42:24 [d7b665da69c27] exiting daemon
13:42:24 [d768e59ef6e25] exiting daemon
13:42:49 |
vendor.conf
Outdated
There was a problem hiding this comment.
Is it wise to update to 3.3 here?
Swarmkit still only has 3.2.1.
There was a problem hiding this comment.
Yeah, we discussed this with @thaJeztah not sure either 😓
I can remove the bump from there and try to update to latest etcd in swarmkit and moby 👼
There was a problem hiding this comment.
I saw it being updated in the UCP repository, so worth checking there as well if it's causing issues in SwarmKit
5cd3088 to
a0d586b
Compare
a0d586b to
708ecb9
Compare
|
@vdemeester needs a rebase |
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
708ecb9 to
b0d108a
Compare
A bit related to docker/cli#1230 (i.e. make more of the common deps referering to the same version)
Signed-off-by: Vincent Demeester vincent@sbr.pm