Merged
Conversation
After switching to Go 1.12, the format-string causes an error; ``` === Errors cli/config/config_test.go:154:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:217:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:253:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:288:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:435:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:448:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile DONE 1115 tests, 2 skipped, 6 errors in 215.984s make: *** [Makefile:22: test-coverage] Error 2 Exited with code 2 ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Merged
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
=======================================
Coverage 56.18% 56.18%
=======================================
Files 306 306
Lines 21006 21006
=======================================
Hits 11803 11803
Misses 8349 8349
Partials 854 854 |
tiborvass
reviewed
Mar 13, 2019
| t.Fatalf("Missing data from parsing:\n%q", config) | ||
| } | ||
| assert.Equal(t, ac.Username, "joejoe") | ||
| assert.Equal(t, ac.Password, "hello") |
Collaborator
There was a problem hiding this comment.
Aren't we losing information here in case of a failure?. Previously we would have been able to see the config that fails the test (and the password with it jk :P)
Collaborator
There was a problem hiding this comment.
@tiborvass right, but that's not what we check at all 👼. We can still add a comment to these assert with the config if we want 😉
Member
Author
|
@tiborvass ready to go, or do you want me to update? |
tiborvass
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After switching to Go 1.12, the format-string causes an error;