[18.09 backport] Fix test for Go 1.12.x#1734
Merged
silvin-lubecki merged 1 commit intodocker:18.09from Mar 14, 2019
Merged
Conversation
After switching to Go 1.12, the format-string causes an error; ``` === Errors cli/config/config_test.go:154:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:217:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:253:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:288:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:435:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile cli/config/config_test.go:448:3: Fatalf format %q has arg config of wrong type *github.com/docker/cli/cli/config/configfile.ConfigFile DONE 1115 tests, 2 skipped, 6 errors in 215.984s make: *** [Makefile:22: test-coverage] Error 2 Exited with code 2 ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit d4877fb) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @silvin-lubecki @vdemeester PTAL |
Codecov Report
@@ Coverage Diff @@
## 18.09 #1734 +/- ##
=======================================
Coverage 54.09% 54.09%
=======================================
Files 290 290
Lines 19406 19406
=======================================
Hits 10498 10498
Misses 8236 8236
Partials 672 672 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #1712 for 18.09. In preparation of future Go updates
After switching to Go 1.12, the format-string causes an error;
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit d4877fb)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)