Skip to content

bump docker/go-units v0.4.0#1844

Merged
silvin-lubecki merged 1 commit intodocker:masterfrom
thaJeztah:bump_go_units
Apr 23, 2019
Merged

bump docker/go-units v0.4.0#1844
silvin-lubecki merged 1 commit intodocker:masterfrom
thaJeztah:bump_go_units

Conversation

@thaJeztah
Copy link
Member

relevant changes:

- docker/go-units#33 Fix handling of unlimited (-1) ulimit values
- docker/go-units#34 Revert 46 minute threshold

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @silvin-lubecki @vdemeester PTAL

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov-io
Copy link

Codecov Report

Merging #1844 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1844   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files         309      309           
  Lines       21614    21614           
=======================================
  Hits        12272    12272           
  Misses       8445     8445           
  Partials      897      897

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1844 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1844   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files         309      309           
  Lines       21614    21614           
=======================================
  Hits        12272    12272           
  Misses       8445     8445           
  Partials      897      897

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 9a0b171 into docker:master Apr 23, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Apr 23, 2019
@thaJeztah thaJeztah deleted the bump_go_units branch April 23, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unlimited hard ulimit with soft limit not supported After running 45 minutes, the docker ps CREATED and STATUS time error

5 participants