Merged
Conversation
This partially reverts commit 57ccf25. Using 46 minutes as a threshold proved to be confusing, given that the human-duration does not use "15 minute" precision anywhere. Before this patch, 47 minutes was shown as "About an hour". With this change, it's shown as "47 minutes". Addresses moby/moby#38807 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@vdemeester @AkihiroSuda PTAL (happy to get your input on this one) |
Member
Author
|
Thinking of pushing a new tag after this one (and my other PR #33) is merged; WDYT; should that be |
AkihiroSuda
approved these changes
Apr 23, 2019
Collaborator
|
I would vote for 0.4.0 |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Apr 23, 2019
relevant changes: - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Apr 23, 2019
relevant changes: - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/containerd
that referenced
this pull request
Apr 23, 2019
relevant changes: - docker/go-units#19 make 1 second not to be plural seconds - docker/go-units#20 Add `HumanSizeWithPrecision` function - docker/go-units#21 change week display rule - docker/go-units#22 Better human duration precision - docker/go-units#23 Removes spaces before unit - docker/go-units#27 Fix containerd#26 - RAMInBytes Bug - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Apr 23, 2019
relevant changes: - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: c94308fa99efe8623fb1a410732609dc45605e9b Component: cli
tiborvass
pushed a commit
to tiborvass/cli
that referenced
this pull request
Apr 23, 2019
relevant changes: - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Apr 24, 2019
relevant changes: - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: c782aef6532b4a30952b84d35b2496d5af1ba1ae Component: engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 57ccf25 (#22).
Using 46 minutes as a threshold proved to be confusing (see moby/moby#38807), given that the human-duration does not use "15 minute" precision anywhere.
Before this patch, 47 minutes was shown as "About an hour". With this change, it's shown as "47 minutes".
Addresses moby/moby#38807