Merged
Conversation
Signed-off-by: Fabiano Franz <ffranz@redhat.com>
Contributor
Author
|
ping @dnephin @vdemeester |
Contributor
|
LGMT |
This was referenced Dec 5, 2016
liggitt
pushed a commit
to liggitt/kubernetes
that referenced
this pull request
Dec 7, 2016
…units Automatic merge from submit-queue (batch tested with PRs 38294, 37009, 36778, 38130, 37835) Bump github.com/docker/go-units dependency <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: Bump [github.com/docker/go-units](https://github.com/docker/go-units/) to include docker/go-units#22 which improves the precision of human durations ("about an hour ago", "2 days ago", etc). **Which issue this PR fixes**: Issue detected in OpenShift: openshift/origin#11967 **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note NONE ```
thaJeztah
added a commit
to thaJeztah/containerd
that referenced
this pull request
Apr 23, 2019
relevant changes: - docker/go-units#19 make 1 second not to be plural seconds - docker/go-units#20 Add `HumanSizeWithPrecision` function - docker/go-units#21 change week display rule - docker/go-units#22 Better human duration precision - docker/go-units#23 Removes spaces before unit - docker/go-units#27 Fix containerd#26 - RAMInBytes Bug - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human duration today rounds hours by simply converting
floattoint, which blindly discards the fraction part. This makes for example 2 hours 59 minutes become just "2 hours". This PR makes it more precise byAdds a few more tests.
Signed-off-by: Fabiano Franz ffranz@redhat.com