Closed
Conversation
allencloud
force-pushed
the
return-uint64-for-parseSize
branch
from
5c3ff84 to
4475901
Compare
Signed-off-by: allencloud <allen.sun@daocloud.io>
allencloud
force-pushed
the
return-uint64-for-parseSize
branch
from
4475901 to
8d2efbf
Compare
Contributor
Author
|
Any update? |
Contributor
|
Seems ok to me, but this change is far from backwards compatible. Is it worth breaking everyone who is using this library? |
Contributor
Author
|
What you said is reasonable. @dnephin Thanks for your feedback. Actually, I did this PR for two reasons:
While, to be honest, backwards compatibility is something I missed, sorry for that. :) |
Member
|
Should we close this PR? |
Contributor
|
If we can't make it backwards compatible I think we should close it. I understand it is more correct, but I'm not sure we gain enough from it to warrant the breaking change. |
Contributor
Author
|
Yes. What you said is totally reasonable. Thanks a lot for your review. @dnephin @thaJeztah I am closing it. |
Member
|
Thanks @allencloud |
thaJeztah
added a commit
to thaJeztah/containerd
that referenced
this pull request
Apr 23, 2019
relevant changes: - docker/go-units#19 make 1 second not to be plural seconds - docker/go-units#20 Add `HumanSizeWithPrecision` function - docker/go-units#21 change week display rule - docker/go-units#22 Better human duration precision - docker/go-units#23 Removes spaces before unit - docker/go-units#27 Fix containerd#26 - RAMInBytes Bug - docker/go-units#33 Fix handling of unlimited (-1) ulimit values - docker/go-units#34 Revert 46 minute threshold Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As parseSize already returns error, so I think there is no need to return -1.
Then we can change returned type from
int64touint64.Signed-off-by: allencloud allen.sun@daocloud.io