docs: document from platform#2003
Closed
tonistiigi wants to merge 1 commit into
Closed
Conversation
tiborvass
reviewed
Jul 12, 2019
| builder assumes a `latest` tag by default. The builder returns an error if it | ||
| cannot find the `tag` value. | ||
|
|
||
| Optional flag `--platform` can be used to specify the platform of the image in |
Collaborator
There was a problem hiding this comment.
Suggested change
| Optional flag `--platform` can be used to specify the platform of the image in | |
| The optional flag `--platform` can be used to specify the platform of the image in |
tiborvass
reviewed
Jul 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
==========================================
- Coverage 56.79% 56.78% -0.01%
==========================================
Files 311 311
Lines 21836 21832 -4
==========================================
- Hits 12402 12398 -4
Misses 8519 8519
Partials 915 915 |
|
Please sign your commits following these rules: $ git clone -b "platform-docs" git@github.com:tonistiigi/docker-cli.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354512184
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
tiborvass
reviewed
Jul 12, 2019
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Co-Authored-By: Tibor Vass <tiborvass@users.noreply.github.com>
cbd228f to
58f4dbc
Compare
Collaborator
|
Necessity for enabling buildkit-mode needs to be mentioned? |
Member
Author
|
@AkihiroSuda There is code to handle this without buildkit as well. I wouldn't recommend it though as all of the useful patterns(cross-compile) are only performant on buildkit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FROM --platformwas added in moby/buildkit#464 but there was no documentation.@thaJeztah @tiborvass
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com