Skip to content

docs: document from platform (carry 2003)#2238

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:carry_platform_docs
Jan 6, 2020
Merged

docs: document from platform (carry 2003)#2238
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:carry_platform_docs

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Carries #2003
closes #2003

#2003 with some nits/comments addressed

Co-Authored-By: Tibor Vass <tiborvass@users.noreply.github.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@ba63a92). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2238   +/-   ##
=========================================
  Coverage          ?   56.78%           
=========================================
  Files             ?      311           
  Lines             ?    21832           
  Branches          ?        0           
=========================================
  Hits              ?    12398           
  Misses            ?     8519           
  Partials          ?      915

@thaJeztah
Copy link
Copy Markdown
Member Author

ping @silvin-lubecki @chris-crone PTAL

Copy link
Copy Markdown
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member Author

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and bring this one in

@thaJeztah thaJeztah merged commit 43c131f into docker:master Jan 6, 2020
@thaJeztah thaJeztah deleted the carry_platform_docs branch January 6, 2020 14:22
@thaJeztah thaJeztah added this to the next milestone Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants