Add interpolation type cast for max_replicas_per_node #2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "fix-max_replicas_per_node_interpolation" git@github.com:rumpl/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
rumpl
force-pushed
the
fix-max_replicas_per_node_interpolation
branch
from
3041997 to
d090152
Compare
thaJeztah
requested changes
Nov 5, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
overall LGTM, but left a comment
cli/compose/loader/loader_test.go
Outdated
| func TestLoadWithInterpolationCastFull(t *testing.T) { | ||
| dict, err := ParseYAML([]byte(` | ||
| version: "3.7" | ||
| version: "3.9" |
Member
There was a problem hiding this comment.
Could you change this to version 3.8? This feature was added in 19.03 (through #1612), which has compose schema 3.8 as maximum
Changing to version 3.8 would allow us to back port this fix
thaJeztah
added
area/stack
impact/compose-file
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
Fixes docker-archive-public/docker.app#688 Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
fix-max_replicas_per_node_interpolation
branch
from
d090152 to
cb29ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes docker-archive-public/docker.app#688
- What I did
Added interpolation type cast mapping for missing
deploy.placement.max_replicas_per_node.- How to verify it
Changed the unit test
- A picture of a cute animal (not mandatory but encouraged)
