[19.03 backport] Add interpolation type cast for max_replicas_per_node #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes docker-archive-public/docker.app#688 Signed-off-by: Djordje Lukic <djordje.lukic@docker.com> (cherry picked from commit cb29ef6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @rumpl @silvin-lubecki PTAL |
Member
|
👍 |
Member
Author
|
ping @silvin-lubecki @tiborvass PTAL |
thaJeztah
changed the title
This comment has been minimized.
This comment has been minimized.
thaJeztah
changed the title
tonistiigi
approved these changes
Jan 16, 2020
Member
Author
|
LGTM |
thaJeztah
deleted the
19.03_backport_fix_max_replicas_per_node_interpolation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2182
Fixes docker-archive-public/docker.app#688
- What I did
Added interpolation type cast mapping for missing
deploy.placement.max_replicas_per_node.- How to verify it
Changed the unit test
- A picture of a cute animal (not mandatory but encouraged)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)