Add device cgroup rules #2206
Add device cgroup rules #2206
Conversation
agners
force-pushed
the
add-device-cgroup-rules
branch
2 times, most recently
from
05d017f to
315e4b2
Compare
|
Any comment on this pull request? Maybe also @ndeloof as you commented on the linked docker compose pull request. |
|
Any comment on this? It is important for us as it enables us to use the 3.x series of Docker Compose schema again... |
|
@thaJeztah friendly ping? This would be valuable for us! |
|
@rgulewich I see that you made recently a change to that file, do you happen to know how to get this reviewed/merged? |
agners
force-pushed
the
add-device-cgroup-rules
branch
from
315e4b2 to
752f3d8
Compare
|
Rebased this pull request. Also created an issue (compose-spec/compose-spec#62) and pull request (compose-spec/compose-spec#63) to add this field in the new compose-spec project. @thaJeztah I think there is no real opposition to adding this, can you help getting this merged? |
This readds support for `device_cgroup_rules` which was present in compose file format 2.4. Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Currently `docker stack deploy` does not support this field hence add it to the list of unsupported fields. Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
agners
force-pushed
the
add-device-cgroup-rules
branch
from
752f3d8 to
468657a
Compare
|
@thaJeztah Since this is now in compose-spec already, any chance to get this merged for Docker 20.03 still? |
Codecov Report
@@ Coverage Diff @@
## master #2206 +/- ##
=======================================
Coverage 58.05% 58.05%
=======================================
Files 295 295
Lines 21165 21165
=======================================
Hits 12288 12288
Misses 7975 7975
Partials 902 902 |
5 participants
This (re-)adds
device_cgroup_rulesto the compose schema. Currently it is not supported by thedocker stack deploycommand. This implements what has been suggested in docker/compose#6974