Skip to content

Conversation

@gh2o
Copy link

@gh2o gh2o commented Oct 19, 2019

It was last present in the 2.4 schema. I could not find why it was removed for 3.0, so I am adding it back in.

This option is needed to selectively share devices between host and container. See here.

It was last present in the 2.4 schema. I could not find why it was
removed for 3.0, so I am adding it back in.

Signed-off-by: Gavin Li <gavin@matician.com>
@agners
Copy link

agners commented Nov 13, 2019

We reverted back to Docker Compose file 2.4 for this feature, it would be nice we can use latest Docker Compose format again.

@ndeloof
Copy link
Contributor

ndeloof commented Nov 18, 2019

Need to also update ServiceConfig and check support by docker stack deploy.

Schema v3.7 is not latest, changes should take place on https://github.com/docker/cli/blob/master/cli/compose/schema/data/ which is the canonical place for compose file schema.

@agners
Copy link

agners commented Nov 27, 2019

@ndeloof oh I see those schemas exist in two places, in the cli repo in cli/compose/schema/data/ as well as the one here under compose/config/. It seems that the cli repo has schemas up to 3.9, so I guess a resync is needed first? This is quite confusing, which one is considered the master?

From what I can tell device_cgroup_rules is not supported in docker stack deploy, so it probably would need to go to the list of UnsupportedProperties for now.

@ndeloof
Copy link
Contributor

ndeloof commented Nov 27, 2019

a resync is indeed needed, see #7047

@agners
Copy link

agners commented May 14, 2020

The property now is part of the upcomming 3.9 version of the compose-spec: compose-spec/compose-spec#63. I guess this merge request can be closed?

SamBissig pushed a commit to toradex/kiosk-mode-browser that referenced this pull request Aug 11, 2020
Add configurations to run Weston and Chromium as regular users inside
the container. The option device_cgroup_rules currently requires
docker-compose to use the 2.4 file format. There is currently a pull
request open to reenable device_cgroup_rules in Docker compose 3.7
file format (see docker/compose#6974).

Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
@gh2o gh2o closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants