Skip to content

Fix bash completion for network create --internal#249

Merged
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion-fix-network-create--internal
Jun 30, 2017
Merged

Fix bash completion for network create --internal#249
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion-fix-network-create--internal

Conversation

@albers
Copy link
Copy Markdown
Collaborator

@albers albers commented Jun 27, 2017

--internal is a boolean option. It was falsely treated as non-boolean, meaning that the next option would not trigger completion.

`--internal` is a boolean option. It was falsely treated as non-boolean.

Signed-off-by: Harald Albers <github@albersweb.de>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 27, 2017

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   46.85%   46.85%           
=======================================
  Files         172      172           
  Lines       11692    11692           
=======================================
  Hits         5478     5478           
  Misses       5902     5902           
  Partials      312      312

Copy link
Copy Markdown
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 17.06.1 milestone Jun 30, 2017
@thaJeztah thaJeztah merged commit b45c7d6 into docker:master Jun 30, 2017
@albers albers deleted the completion-fix-network-create--internal branch June 30, 2017 08:23
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
[17.09] vndr Microsoft/hcsshim to v0.6.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants