This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[17.06] backport various completion script updates#104
Merged
andrewhsu merged 12 commits intoJul 12, 2017
Conversation
thaJeztah
approved these changes
Jul 11, 2017
Contributor
|
It's really hard to keep up with all the changes in Docker. But I figured out how to work with this repo and found a hack that gets the completion script into the dev container. moby/moby#33801 is not present here. I verified the changes successfully. All features are present. The script can be loaded with ancient bash version as well (MacOS). One point though: The implementation of |
Contributor
|
can we also pull in docker/cli#321 (was just merged)? |
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit e4f9ad77c8de298af11a57f9ca89c88fa3d62181) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 8b99b65ca82534edca786a9e3a61d77297626690) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Also fixes a wrong option: `--arg` should be `--args`. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit e0462e8472af1f0835104651e062b35756901d59) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
…from` Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 22579ba56cd5da8fa2808f1041b9dbc65738d40a) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
`--internal` is a boolean option. It was falsely treated as non-boolean. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 12dc9eb11f3e6911a024008dc664fd124f8eb36f) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 8baef1098ecef546040b7582344d4f08aab08dc9) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit f0f71505377ef2af5e51ee07b1b054cd83ec3886) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 71dd0e0b668a5755d89815a9c310c2370680c1dc) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit fa0f470a5f43c11b611afcdfc47d1d985f98553c) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 5bd00a563e9cc013d9d67e4770cae2be65963f98) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit fa4dc8820af82052834d96704f927ec789530be1) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
The `--network` option is only available for `docker service create`. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit e7e77b5e65062006d1e858ab2d4a1cde2651abf2) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Contributor
Author
|
I brought in docker/cli@e7e77b5 and rebased to |
docker-jenkins
pushed a commit
that referenced
this pull request
May 20, 2018
Update go to 1.10.2 Upstream-commit: 1aa5fac Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Nov 1, 2018
[18.09] Vendor swarmkit to 6186e40 Upstream-commit: 4fc9786f7869a823962b7da6c876288b37d8da54 Component: engine
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Update go to 1.10.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport completion script fixes:
docker network create --ingressdocker/cli#239 Add bash completion fordocker network create --ingresslabelfilter ofprunecommands docker/cli#246 Add bash completion forlabelfilter ofprunecommandsservice create|update --entrypointdocker/cli#247 Add bash completion forservice create|update --entrypointnetwork create --scope|--config-only|config-fromdocker/cli#248 Add bash completion fornetwork create --scope|--config-only|config-fromnetwork create --internaldocker/cli#249 Fix bash completion fornetwork create --internalservice create --detachdocker/cli#250 Add bash completion forservice create --detachservice create|update (update|rollback)-orderdocker/cli#256 Add bash completion forservice create|update (update|rollback)-orderservice create|update --network-(add|rm)docker/cli#257 Add bash completion forservice create|update --network-(add|rm)swarm cadocker/cli#268 Add bash completion forswarm caswarm init|join --data-path-addrdocker/cli#269 Fix bash completion forswarm init|join --data-path-addrservice update --networkdocker/cli#321 Remove bash completion forservice update --networkwith cherry-pick (each PR only had one commit):