Skip to content

Remove bash completion for service update --network#321

Merged
vieux merged 1 commit into
docker:masterfrom
albers:remove-completion-service-update--network
Jul 11, 2017
Merged

Remove bash completion for service update --network#321
vieux merged 1 commit into
docker:masterfrom
albers:remove-completion-service-update--network

Conversation

@albers
Copy link
Copy Markdown
Collaborator

@albers albers commented Jul 11, 2017

The --network option is only valid for docker service create.
This PR removes it from bash completion for docker service update (which has --network-add and --network-rm instead).

The `--network` option is only available for `docker service create`.

Signed-off-by: Harald Albers <github@albersweb.de>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 11, 2017

Codecov Report

Merging #321 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   48.67%   48.68%   +<.01%     
==========================================
  Files         186      186              
  Lines       12416    12416              
==========================================
+ Hits         6044     6045       +1     
+ Misses       5997     5996       -1     
  Partials      375      375

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Jul 11, 2017

LGTM

@vieux vieux merged commit 251eafd into docker:master Jul 11, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jul 11, 2017
@albers albers deleted the remove-completion-service-update--network branch July 11, 2017 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants