Fix bash completion for swarm init|join --data-path-addr#269
Merged
vdemeester merged 1 commit intoJun 30, 2017
Merged
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 46.84% 46.85% +<.01%
==========================================
Files 172 172
Lines 11692 11692
==========================================
+ Hits 5477 5478 +1
+ Misses 5903 5902 -1
Partials 312 312 |
Member
|
ping @vdemeester PTAL |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
[17.10] update changelog for 17.10.0-ce-rc2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bash completion for
swarm init --data-path-addrandswarm join --data-path-addrtreated--data-path-addras a boolean option.This fix adds completion for interfaces and local addresses, similar to
--advertise-addr(but without trailing port).Also corrects sort order of options.
Ping @sdurrheimer for zsh completion