Add bash completion for service create|update --network-(add|rm)#257
Merged
Merged
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 46.85% 46.85%
=======================================
Files 172 172
Lines 11692 11692
=======================================
Hits 5478 5478
Misses 5902 5902
Partials 312 312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds bash completion for moby/moby#32062.
Ping @sdurrheimer for zsh completion
Note: In the completion for
docker service update --network-rm, it would be nice to only complete networks that are actually connected to the service. Sadly, at this point of typing, the service is not known yet - it's the last argument. So I have to complete all networks here.