Skip to content

cli/command/container/stats.go: fix goimports #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiborvass merged 1 commit into from
Nov 10, 2020
Merged

cli/command/container/stats.go: fix goimports #2836

tiborvass merged 1 commit into from
Nov 10, 2020

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Nov 10, 2020 

cli/command/container/stats.go:159: File is not `goimports`-ed (goimports)

@thaJeztah
cli/command/container/stats.go: fix goimports
ae5899e 
    cli/command/container/stats.go:159: File is not `goimports`-ed (goimports)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 20.10.0 milestone Nov 10, 2020
@thaJeztah
Copy link
Member Author

thaJeztah commented Nov 10, 2020

Not sure why it started failing all of a sudden 🤷‍♂️

thaJeztah
thaJeztah commented Nov 10, 2020
View reviewed changes
cli/command/container/stats.go
// containers.
getContainerList()

Copy link
Member Author

@thaJeztah thaJeztah Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really odd; last PR was #2785, and that commit doesn't show the whitespace 🤔 ??? 53e2110

Copy link
Member Author

@thaJeztah thaJeztah Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the "blame" view doesn't show the whitespace; https://github.com/docker/cli/blame/b07e921289f7d3ec80e91636d7979298975ea210/cli/command/container/stats.go#L159

Screenshot 2020-11-10 at 17 53 43

Copy link
Member Author

@thaJeztah thaJeztah Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checking the diff on the PR, and it doesn't show the whitespace; I checked if I had "hide whitespace changes" enabled, but I don't; https://github.com/docker/cli/pull/2785/files

Screenshot 2020-11-10 at 17 55 34

This was referenced Nov 10, 2020
Merged
Merged
@tiborvass tiborvass merged commit 4c12f1a into docker:master Nov 10, 2020
@thaJeztah thaJeztah deleted the fix_goimports branch November 10, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiborvass tiborvass tiborvass approved these changes

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @tiborvass