Skip to content

cli/command/container/stats.go: fix goimports #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiborvass merged 1 commit into from
Nov 10, 2020
Merged

cli/command/container/stats.go: fix goimports #2836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/command/container/stats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func runStats(dockerCli command.Cli, opts *statsOptions) error {
// Start a short-lived goroutine to retrieve the initial list of
// containers.
getContainerList()

Copy link
Member Author

@thaJeztah thaJeztah Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really odd; last PR was #2785, and that commit doesn't show the whitespace 🤔 ??? 53e2110

Copy link
Member Author

@thaJeztah thaJeztah Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the "blame" view doesn't show the whitespace; https://github.com/docker/cli/blame/b07e921289f7d3ec80e91636d7979298975ea210/cli/command/container/stats.go#L159

Screenshot 2020-11-10 at 17 53 43

Copy link
Member Author

@thaJeztah thaJeztah Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checking the diff on the PR, and it doesn't show the whitespace; I checked if I had "hide whitespace changes" enabled, but I don't; https://github.com/docker/cli/pull/2785/files

Screenshot 2020-11-10 at 17 55 34

// make sure each container get at least one valid stat data
waitFirst.Wait()
} else {
Expand All @@ -175,7 +175,7 @@ func runStats(dockerCli command.Cli, opts *statsOptions) error {

// make sure each container get at least one valid stat data
waitFirst.Wait()

var errs []string
cStats.mu.Lock()
for _, c := range cStats.cs {
Expand Down