Skip to content

Fix the (dead) link for docs for Dockerfile syntax reference#3164

Merged
thaJeztah merged 1 commit intodocker:masterfrom
tnir:dockerfile-syntax
Dec 8, 2021
Merged

Fix the (dead) link for docs for Dockerfile syntax reference#3164
thaJeztah merged 1 commit intodocker:masterfrom
tnir:dockerfile-syntax

Conversation

@tnir
Copy link
Contributor

@tnir tnir commented Jun 28, 2021

This change will update the docs at https://docs.docker.com/engine/reference/builder/#buildkit

moby/buildkit#1884 requires this change on the docs.

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

- What I did

This change a sentence with a valid URL for the link in https://docs.docker.com/engine/reference/builder/#buildkit

- How I did it

Follows the link

- How to verify it

moby/buildkit#1884 showed us Dockerfile got GA'ed.

- Description for the changelog

Fix the docs for Dockerfile syntax reference

- A picture of a cute animal (not mandatory but encouraged)

🐱

This change will update the docs at
https://docs.docker.com/engine/reference/builder/#buildkit

This change is required by moby/buildkit#1884

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir requested a review from thaJeztah as a code owner June 28, 2021 06:13
@codecov-commenter
Copy link

Codecov Report

Merging #3164 (0c723fd) into master (8e08b72) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3164   +/-   ##
=======================================
  Coverage   57.09%   57.09%           
=======================================
  Files         299      299           
  Lines       18731    18731           
=======================================
  Hits        10695    10695           
  Misses       7166     7166           
  Partials      870      870           

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah added this to the 21.xx milestone Dec 8, 2021
@thaJeztah thaJeztah merged commit 6067738 into docker:master Dec 8, 2021
@tnir tnir deleted the dockerfile-syntax branch March 7, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants