Skip to content

docs: update external dockerfile docs#1884

Merged
tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi:dockerfile-docs-update
Dec 9, 2020
Merged

docs: update external dockerfile docs#1884
tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi:dockerfile-docs-update

Conversation

@tonistiigi
Copy link
Member

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi tonistiigi force-pushed the dockerfile-docs-update branch from 7d0b9ea to 40f0f72 Compare December 9, 2020 04:00
users use the same version on the builder and to pick up bugfixes automatically without waiting for a new version of BuildKit
or Docker engine.

The images are published on two channels: *latest* and *labs*. The latest channel uses semver versioning while labs uses a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The images are published on two channels: *latest* and *labs*. The latest channel uses semver versioning while labs uses a
The images are published on two channels: *latest* and *labs*. The latest channel uses semver versioning while labs uses an

or Docker engine.

The images are published on two channels: *latest* and *labs*. The latest channel uses semver versioning while labs uses a
[incrementing number](https://github.com/moby/buildkit/issues/528). This means labs channel may remove a feature without
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[incrementing number](https://github.com/moby/buildkit/issues/528). This means labs channel may remove a feature without
[incrementing number](https://github.com/moby/buildkit/issues/528). This means the labs channel may remove a feature without

Copy link
Collaborator

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits that came from experimental.md. Feel free to merge

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the dockerfile-docs-update branch from 40f0f72 to 9f6172c Compare December 9, 2020 05:26
@tonistiigi tonistiigi merged commit 8c7c526 into moby:master Dec 9, 2020
#### Example: cache Go packages

```dockerfile
# syntax = docker/dockerfile:experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it have been better to use the new tag labs?

tnir added a commit to tnir/cli that referenced this pull request Jun 28, 2021
This change will update the docs at
https://docs.docker.com/engine/reference/builder/#buildkit

This change is required by moby/buildkit#1884

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Dec 8, 2021
This change will update the docs at
https://docs.docker.com/engine/reference/builder/#buildkit

This change is required by moby/buildkit#1884

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Upstream-commit: 0c723fd68ae75a69090fad4a858d32e014b79b0a
Component: cli
thaJeztah pushed a commit to thaJeztah/cli that referenced this pull request Feb 18, 2022
This change will update the docs at
https://docs.docker.com/engine/reference/builder/#buildkit

This change is required by moby/buildkit#1884

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
(cherry picked from commit 0c723fd)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
crazy-max pushed a commit to crazy-max/buildkit that referenced this pull request Jun 8, 2022
This change will update the docs at
https://docs.docker.com/engine/reference/builder/#buildkit

This change is required by moby#1884

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants