Skip to content

Conversation

@PeterDaveHello
Copy link
Contributor

- What I did

Update most links in docs to use https by default, http is not safe at all.

Suggested by cc @thaJeztah in docker/docs#13680

- How I did it

Find out all http links in docs:

~/repos/docker/cli $ git grep 'http:' docs/

and check if they support https or redirect to https by default, then replace those with https supprot:

- How to verify it

Use curl and browser to check the updated links work like before this change.

- Description for the changelog

Update most links in docs to use https by default

cc @thaJeztah docker/docs#13680

Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
@codecov-commenter
Copy link

Codecov Report

Merging #3339 (417f976) into master (9fab13b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3339   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files         302      302           
  Lines       21764    21764           
=======================================
  Hits        12621    12621           
  Misses       8219     8219           
  Partials      924      924           

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I checked if all these domains had TLS (there were some in the past that didn't), and left some notes for follow ups (no show-stoppers, so I'm happy with merging this as-is for now)

## boot2docker

[boot2docker](http://boot2docker.io/) is a lightweight Linux distribution made
[boot2docker](https://boot2docker.io/) is a lightweight Linux distribution made
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they had this domain expire, and it's now used by someone else. That said, this glossary is really outdated, and there's a different glossary in the documentation repository itself (https://docs.docker.com/glossary/).

We should probably have e a look at merging this content with the glossary in the documentation repository and remove it here (in a follow up)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe just entirely remove it?

https://github.com/boot2docker/boot2docker

Boot2Docker is officially deprecated and unmaintained.

host as processes running outside containers on the host. Additional
information about running with `--privileged` is available on the
[Docker Blog](http://blog.docker.com/2013/09/docker-can-now-run-within-docker/).
[Docker Blog](https://blog.docker.com/2013/09/docker-can-now-run-within-docker/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self; this redirects to https://www.docker.com/blog/docker-can-now-run-within-docker/ (perhaps we should update to the new location to skip the redirect)

@thaJeztah thaJeztah merged commit 17e24a1 into docker:master Oct 15, 2021
@PeterDaveHello PeterDaveHello deleted the update-docs branch October 15, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants