Update most links to use https by default #13680
Conversation
|
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: ed135fe 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/61653d71b8366a000767858d 😎 Browse the preview: https://deploy-preview-13680--docsdocker.netlify.app |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! Changes LGTM, but left a comment about some generated YAML files that were updated (which would also need to be updated in the upstream CLI repository to prevent the changes from being reverted at some point)
| the given template will be executed for each result. | ||
| Go's [text/template](http://golang.org/pkg/text/template/) package | ||
| Go's [text/template](https://golang.org/pkg/text/template/) package |
There was a problem hiding this comment.
The YAML files in the _data/engine-cli directory are generated from MarkDown source files in the CLI repository. For example, this page is generated from https://github.com/docker/cli/blob/master/docs/reference/commandline/config_inspect.md
So changes made in these YAML files will be overwritten when these files are regenerated and updated. Perhaps you're interested in opening a pull request with these changes in the CLI repository? https://github.com/docker/cli
When doing so, be sure to include a DCO sign-off line (Signed-Off-By) line in the commit message (see https://github.com/docker/cli/blob/master/CONTRIBUTING.md#sign-your-work), otherwise CI will fail in that repository.
I'm also happy to make those changes if you want
There was a problem hiding this comment.
Ah, I see you're already using a DCO for your commits, so you probably don't need the instructions 😂
There was a problem hiding this comment.
Okay I'll take a look at docker/cli, thanks.
cc @thaJeztah docker/docs#13680 Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
cc @thaJeztah docker/docs#13680 Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org> (cherry picked from commit 417f976) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cc @thaJeztah docker/docs#13680 Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org> Upstream-commit: 417f97605f547a44d721225c26a9bdbf2600a991 Component: cli
cc @thaJeztah docker/docs#13680 Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
cc @thaJeztah docker/docs#13680 Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
cc @thaJeztah docker/docs#13680 Signed-off-by: Peter Dave Hello <hsu@peterdavehello.org>
2 participants
Proposed changes
Update most links to use https by default for better security practice
Related issues (optional)