Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 27, 2022

follow-up to #3310

The COMPANY_NAME currently sets the "CompanyName" field in the metadata
of Windows binaries. Our intent of this field is this field to contain
information about the company/party that produced the binary.

Also from FileVersionInfo.CompanyName:

Gets the name of the company that produced the file

Based on the above, "PACKAGER_NAME" is a bit more generic, and clearer
on intent, and we may at some point re-use this same information to
propagate equivalent fields on other platforms (rpms, debs)

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

The COMPANY_NAME currently sets the "CompanyName" field in the metadata
of Windows binaries. Our intent of this field is this field to contain
information about the company/party that produced the binary.

Also from [FileVersionInfo.CompanyName][FileVersionInfo.CompanyName]:

> Gets the name of the company that produced the file

Based on the above, "PACKAGER_NAME" is a bit more generic, and clearer
on intent, and we may at some point re-use this same information to
propagate equivalent fields on other platforms (rpms, debs)

[FileVersionInfo.CompanyName]: https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.fileversioninfo.companyname

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022

Codecov Report

Merging #3500 (4cd2d9d) into master (dd73973) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3500   +/-   ##
=======================================
  Coverage   59.01%   59.01%           
=======================================
  Files         284      284           
  Lines       23833    23833           
=======================================
  Hits        14066    14066           
  Misses       8908     8908           
  Partials      859      859           

@thaJeztah
Copy link
Member Author

We should also have a look at the LegalTrademarks field; looks like we currently leave it empty, but perhaps would be good to (at some point) also set it.

It's a bit ambiguous though what should be in there (initially I thought that should contain something like "docker, the docker logo, and... are trademarks of docker. inc.", but the description from https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.fileversioninfo.legaltrademarks?view=net-6.0 describes it as:

The legal trademarks include the full text of all notices, legal symbols, and trademark numbers.

Which would potentially mean all NOTICE files of source we use, so we need to check what should be in that field.

@thaJeztah
Copy link
Member Author

Alpine having an outage?

#26 [linux/amd64 build-base-alpine 3/4] RUN apk add --no-cache bash clang lld llvm file git
#26 130.1 WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.15/main: network error (check Internet connection and firewall)
#26 130.1 fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/x86_64/APKINDEX.tar.gz
#26 261.2 WARNING: Ignoring https://dl-cdn.alpinelinux.org/alpine/v3.15/community: network error (check Internet connection and firewall)
#26 261.2 ERROR: unable to select packages:
#26 261.2   bash (no such package):
#26 261.2     required by: world[bash]

@thaJeztah thaJeztah merged commit 8c58da1 into docker:master Mar 27, 2022
@thaJeztah thaJeztah deleted the packager_name branch March 27, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants