[master] makefile: add PACKAGER_NAME common variable #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Mar 26, 2022
common.mk
Outdated
| BUILDTIME=$(shell date -u -d "@$${SOURCE_DATE_EPOCH:-$$(date +%s)}" --rfc-3339 ns 2> /dev/null | sed -e 's/ /T/') | ||
| CHOWN:=docker run --rm -v $(CURDIR):/v -w /v alpine chown | ||
| DEFAULT_PRODUCT_LICENSE:=Community Engine | ||
| COMPANY_NAME:=Docker, Inc. |
Member
There was a problem hiding this comment.
perhaps it should be empty by default (but we can set it in our internal pipeline)
that way, someone using the code from this repository doesn't set docker's name as packager
Member
|
I just realised we discussed naming of this variable on Slack, but already used |
thaJeztah
changed the title
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up docker/cli#3310 and moby/moby#43431
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com