Skip to content

Conversation

@crazy-max
Copy link
Member

+ cat ./cli/winresources/versioninfo.json
{
  "FixedFileInfo":
  {
    "FileVersion": {
      "Major": 22,
      "Minor": 04,
      "Patch": 0,
      "Build": 0
    },
    "FileFlagsMask": "3f",
    "FileFlags ": "00",
    "FileOS": "040004",
    "FileType": "01",
    "FileSubType": "00"
  },
  "StringFileInfo":
  {
    "Comments": "",
    "CompanyName": "",
    "FileDescription": "Docker Client",
    "FileVersion": "22.04.0-beta.0",
    "InternalName": "",
    "LegalCopyright": "Copyright © 2015-2022 Docker Inc.",
    "LegalTrademarks": "",
    "OriginalFilename": "docker-windows-amd64.exe",
    "PrivateBuild": "",
    "ProductName": "Docker Client",
    "ProductVersion": "22.04.0-beta.0",
    "SpecialBuild": "58d425d"
  },
  "VarFileInfo":
  {
    "Translation": {
      "LangID": "0409",
      "CharsetID": "04B0"
    }
  }
}
2022/03/31 13:16:40 Could not parse the .json file: invalid character '4' after object key:value pair
cmd/docker/docker_windows_amd64.go:4: running "goversioninfo": exit status 2
ERROR: executor failed running [/bin/sh -c xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "$GO_LINKMODE" = "static" ] && echo "--static") /out/docker]: exit code: 1
------
 > [build 3/3] RUN --mount=type=bind,target=.,ro     --mount=type=cache,target=/root/.cache     --mount=from=dockercore/golang-cross:xx-sdk-extras,target=/xx-sdk,src=/xx-sdk     --mount=type=tmpfs,target=cli/winresources     xx-go --wrap &&     TARGET=/out ./scripts/build/binary &&     xx-verify $([ "static" = "static" ] && echo "--static") /out/docker:
}

cc @thaJeztah

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@thaJeztah thaJeztah merged commit b1ce915 into docker:master Mar 31, 2022
@crazy-max crazy-max deleted the fix-version-quad branch March 31, 2022 17:42
@crazy-max
Copy link
Member Author

I will that on moby/moby#43431 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants