-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix version quad logic that trims 0 digit so returns an empty one #3519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c7117f to
465d4a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #3519 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 284 284
Lines 23839 23839
=======================================
Hits 14066 14066
Misses 8914 8914
Partials 859 859 |
465d4a0 to
753c764
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
753c764 to
22edabb
Compare
|
Interesting; panic in a test; should not be related, but wondering what caused it: empty slice somewhere, causing |
|
opened #3520 to fix the test |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
relates to docker/docker-ce-packaging#669 |
follow-up #3517
cc @thaJeztah
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com