Add zsh completion for docker service scale --detach=false#389
Merged
Conversation
Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr>
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 46.14% 46.14%
=======================================
Files 193 193
Lines 16073 16073
=======================================
Hits 7417 7417
Misses 8269 8269
Partials 387 387 |
vdemeester
approved these changes
Aug 1, 2017
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 👼
/cc @sdurrheimer
sdurrheimer
reviewed
Aug 2, 2017
| (scale) | ||
| _arguments $(__docker_arguments) \ | ||
| $opts_help \ | ||
| "($help -d --detach)"{-d=false,--detach=false}"[Disable detached mode]" \ |
Contributor
There was a problem hiding this comment.
Boolean flag doesn't need =false.
Sorry for the delay, I have not a lot of time these days.
Contributor
Author
There was a problem hiding this comment.
Thanks I'll change that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zsh completion equivalent of #382 for the flag option in #243.
Signed-off-by: Jean-Pierre Huynh jean-pierre.huynh@ounet.fr