Skip to content

Add zsh completion for docker service scale --detach=false #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Aug 1, 2017
Merged

Add zsh completion for docker service scale --detach=false #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contrib/completion/zsh/_docker
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,6 +2040,7 @@ __docker_service_subcommand() {
(scale)
_arguments $(__docker_arguments) \
$opts_help \
"($help -d --detach)"{-d=false,--detach=false}"[Disable detached mode]" \
Copy link
Copy Markdown
Contributor

@sdurrheimer sdurrheimer Aug 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boolean flag doesn't need =false.

Sorry for the delay, I have not a lot of time these days.

Copy link
Copy Markdown
Contributor Author

@jphuynh jphuynh Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I'll change that.

"($help -)*:service:->values" && ret=0
case $state in
(values)
Expand Down