cli/container: Don't ignore error when parsing volume spec #4415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
status/2-code-review
process/cherry-pick
area/volumes
kind/bugfix
vvoland
force-pushed
the
dont-ignore-volume-parse-err
branch
2 times, most recently
from
94f6d36 to
6ad527b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4415 +/- ##
==========================================
- Coverage 59.41% 59.40% -0.01%
==========================================
Files 288 288
Lines 24776 24778 +2
==========================================
- Hits 14720 14719 -1
- Misses 9171 9173 +2
- Partials 885 886 +1 |
Member
|
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
dont-ignore-volume-parse-err
branch
from
6ad527b to
fe7afb7
Compare
Collaborator
Author
|
Yes, this also fixes that issue: $ ./build/docker run -v "" alpine
docker: invalid volume specification: invalid empty volume spec.
See 'docker run --help'.Added e2e test for it: TestCreateWithEmptyVolumeSpec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: Improve volume spec parsing #152
Fixes: Empty string "--volume" causes unhelpful error messages #4053
- What I did
Handle error when parsing an invalid volume spec.
This was discovered when analyzing issue reported by @trungutt where
docker run -v $empty_var:/vol alpinewould result in anonymous volume being mounted at/vol.- How I did it
- How to verify it
CI tests:
unit: TestParseVolumeWithEmptySource
e2e: TestCreateWithEmptySourceVolume
e2e: TestCreateWithEmptyVolumeSpec
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)