[24.0 backport] cli/container: Don't ignore error when parsing volume spec #4423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit fe7afb7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
impact/changelog
status/2-code-review
area/volumes
kind/bugfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 24.0 #4423 +/- ##
==========================================
+ Coverage 58.92% 59.28% +0.36%
==========================================
Files 286 288 +2
Lines 24797 24806 +9
==========================================
+ Hits 14611 14706 +95
+ Misses 9301 9213 -88
- Partials 885 887 +2 |
vvoland
approved these changes
Jul 17, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Handle error when parsing an invalid volume spec.
This was discovered when analyzing issue reported by @trungutt where
docker run -v $empty_var:/vol alpinewould result in anonymous volume being mounted at/vol.- How I did it
- How to verify it
CI tests:
unit: TestParseVolumeWithEmptySource
e2e: TestCreateWithEmptySourceVolume
e2e: TestCreateWithEmptyVolumeSpec
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
(cherry picked from commit fe7afb7)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)