Bump moby vendor to 14ce1f1cf48e9859223c6311de58aec4dc #570
Conversation
| } | ||
|
|
||
| return archive.PreserveTrailingDotOrSeparator(absPath, localPath), nil | ||
| return archive.PreserveTrailingDotOrSeparator(absPath, localPath, filepath.Separator), nil |
There was a problem hiding this comment.
ping @johnstep to check if this one is correct (LCOW related)
|
ping @dnephin @vdemeester if we want this updated before 17.10 is cut off |
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 49.42% 49.39% -0.04%
==========================================
Files 208 208
Lines 17164 17175 +11
==========================================
Hits 8483 8483
- Misses 8248 8259 +11
Partials 433 433 |
thaJeztah
changed the title
|
FYI: running locally (D4M), it got stuck at; |
@thaJeztah If you're running without |
vendor.conf
Outdated
| # TODO remove this once tonistiigi/fsutil switched, and was vendored (https://github.com/tonistiigi/fsutil/pull/15) | ||
| github.com/stevvooe/continuity 22694c680ee48fb8f50015b44618517e2bde77e8 | ||
| github.com/moby/buildkit aaff9d591ef128560018433fe61beb802e149de8 | ||
| github.com/tonistiigi/fsutil 1dedf6e90084bd88c4c518a15e68a37ed1370203 |
There was a problem hiding this comment.
Let's keep this file sorted alphabetically instead of these adhoc groupings
Oh! I saw that popup, then go away so thought it worked; yes, that would explain it! |
…0f046c Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump-moby-vendor
branch
from
b452235 to
0082310
Compare
|
vendor.conf updated to be in alphabetical order again; PTAL |
|
ready to go, or do we need a check from @johnstep for #570 (comment) ? |
|
discussed offline with @dnephin ^^ |
5 participants
This includes a fix for API version negotiation: moby/moby#35008
I may need some help on this one w.r.t. the local changes needed; unit-tests hung for me locally, so likely I messed something up, but pushed here as a startedit: looks like hanging may be just with me locally; I'll have to check why..