revendor logrus and x/crypto #572
Conversation
updates to the same version as is currently used on moby/moby; this bump contains fixes for ppc64le. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 49.41% 49.41% -0.01%
==========================================
Files 208 208
Lines 17164 17164
==========================================
- Hits 8482 8481 -1
- Misses 8249 8250 +1
Partials 433 433 |
|
thanks @thaJeztah for these bumps. i see no issues with this. |
tophj-ibm
left a comment
tophj-ibm
left a comment
There was a problem hiding this comment.
I am seeing an issue where docker trust is outputting my passphrase to the terminal, but it doesn't seem to be related to this pr. I'll open an issue in notary. This LGTM
|
@tophj-ibm: that's unexpected - is it the same for |
riyazdf
left a comment
riyazdf
left a comment
There was a problem hiding this comment.
this change LGTM.
@tophj-ibm and I have been working on community slack to diagnose the issue with the passphrase library in notary. It seems to be isolated to power. I'll file an issue on notary
|
thanks for reviewing! |
|
LGTM |
8 participants
I originally had these in #570, but didn't know if the x/crypto changes would affect the recently added
docker trustcommands (#472), so decided to keep it separate.These dependencies were bumped upstream in moby/moby#34332 to address some issues with PowerPC64le
ping @riyazdf @clnperez @tophj-ibm PTAL