Resolve environment without values to values on host #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Author
|
@aanand This is an implementation of what you suggested in # 1 of your comment on #227. Just wanted to make sure you saw it. |
|
Yes! Was trying it out earlier - looks good. I'll merge it tomorrow. On Tue, Jul 8, 2014 at 10:09 PM, Ryan Brainard notifications@github.com
|
|
Would be good to get documentation too. |
Author
|
@bfirsh Just added documentation |
|
Great, thanks! Needs rebasing against master too. |
For parity with the Docker CLI, allow environment variables without values to be automatically resolved to their values on the host. Signed-off-by: Ryan Brainard <brainard@heroku.com> Conflicts: tests/integration/service_test.py
Signed-off-by: Ryan Brainard <brainard@heroku.com>
Author
|
@bfirsh Rebased and re-ran tests. |
|
Great stuff! Thanks so much, Ryan. |
bfirsh
added a commit
that referenced
this pull request
Jul 11, 2014
Resolve environment without values to values on host
Author
|
Thank you! :) |
Closed
This was referenced Dec 9, 2014
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Resolve environment without values to values on host Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
xulike666
pushed a commit
to xulike666/compose
that referenced
this pull request
Jan 19, 2017
Sigchld reaper has been removed from containerd procss in 8476905, so the comment is not need any more. Signed-off-by: Lei Jitang <leijitang@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parity with the Docker CLI, allow environment variables without values to be automatically resolved to their values on the host.
If someone defines an
environmentas alist, this also converts it to adictso the above resolution works as expected. Definingenvironmentasdictis canonical, but using alistalready worked, so this conversion supports backward compatibility.docker-py resolves
environmentwith a value ofNoneto the string'None', which is not what someone would want if the value could not be found in the host's environment. This resolves that case to empty string, which is how Docker CLI also handles this situation.Fixes #277