-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add support for docker run --tmpfs flag. #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please sign your commits following these rules: $ git clone -b "master" git@github.com:sllawap/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Philip Walls <pawalls@rabidgeek.com>
Signed-off-by: Philip Walls <pawalls@rabidgeek.com>
|
@GordonTheTurtle -- should be all set now. Sorry for the oversight; first time contributor! |
|
I tried to test this PR, because I wanted to check whether syntax like However, I did not manage to run the PR (see error below). I think support for tmpfs is needed in docker-py, maybe? Consider the following docker-compose.yml: version: "2"
services:
test:
image: busybox
tmpfs: /run
network_mode: noneI run: It fails with: Traceback (most recent call last):
File "bin/docker-compose", line 3, in <module>
main()
File ".../src/compose/compose/cli/main.py", line 56, in main
command.sys_dispatch()
[…]
File ".../src/compose/compose/service.py", line 648, in _get_container_host_config
tmpfs=options.get('tmpfs'),
File ".../Library/Python/Envs/compose/lib/python2.7/site-packages/docker/api/container.py", line 141, in create_host_config
return utils.create_host_config(*args, **kwargs)
TypeError: create_host_config() got an unexpected keyword argument 'tmpfs'I looked at the AppVeyor logs, but I didn’t see the |
| 'external_links', | ||
| 'ports', | ||
| 'volumes_from', | ||
| 'tmpfs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this can be a list or a string it needs to be in the list with dns and dns_search just below this line.
|
Thanks for the PR! I've left one comment about a fix. If this requires a specific pre-release version of |
|
Carried in #3137 |
|
@dnephin sorry for neglecting this, I was on vacation. Thank you for pushing this through! |
This adds support for the docker run --tmpfs flag as described in #2778