Skip to content

Conversation

@dnephin
Copy link

@dnephin dnephin commented Mar 15, 2016

Carry #2978
Fixes #2778

@dnephin
Copy link
Author

dnephin commented Mar 15, 2016

Oh, this is still blocked on docker/docker-py#939, I didn't realize

@dnephin dnephin force-pushed the add_tmpfs_to_config branch from 6c83887 to f6f4fa9 Compare March 17, 2016 02:18
@dnephin
Copy link
Author

dnephin commented Mar 17, 2016

Updated the docker-py sha, let's see if we get a green build now.

@aanand
Copy link

aanand commented Mar 17, 2016

Looks like tmpfs is still getting passed to create_container, not (just) create_host_config?

@dnephin dnephin force-pushed the add_tmpfs_to_config branch 2 times, most recently from 4133be8 to 9a3c7d3 Compare March 17, 2016 19:40
@dnephin
Copy link
Author

dnephin commented Mar 18, 2016

Test runs are still flaking, but the test passes locally, so it should be unrelated.

dnephin and others added 2 commits March 18, 2016 18:19
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Philip Walls <pawalls@rabidgeek.com>
@dnephin dnephin force-pushed the add_tmpfs_to_config branch from 9a3c7d3 to 85c7d3e Compare March 18, 2016 22:20
@aanand
Copy link

aanand commented Mar 21, 2016

LGTM

aanand added a commit that referenced this pull request Mar 21, 2016
Add support for docker run --tmpfs flag.
@aanand aanand merged commit 2812014 into docker:master Mar 21, 2016
@dnephin dnephin deleted the add_tmpfs_to_config branch March 21, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants