Skip to content

Conversation

@scottynomad
Copy link

Just wired up the ability to set the workdir when using fig run.

@aanand
Copy link

aanand commented Jul 22, 2014

Nice job, but is there a compelling use case for passing -w rather than just setting working_dir in fig.yml?

(...other than that it's undocumented...)

@scottynomad
Copy link
Author

Ah, I missed the undocumented working_dir in fig.yml. That will be useful! I just found myself looking for the command line switch a few times recently when debugging my container setups.

@d11wtq
Copy link

d11wtq commented Jul 23, 2014

I'm generally in favour of supporting command line overrides for things in fig.yml, as long as the defaults don't require you to pass any specific command line flags.

@aanand
Copy link

aanand commented Jul 23, 2014

While the current parameters for fig run (-d, -T, --rm, --no-deps) make sense to me as things you might want to change at runtime, I'm struggling to think of a common use case where you'd want to override the working dir without just going into fig.yml and changing it.

For that reason, I think I'm -1 on merging this, since the logical extension would be to support absolutely every docker run parameter, and that'll involve a lot of glue code.

@scottynomad
Copy link
Author

That's fair. I'm glad to know about the fig.yml option!

@aanand
Copy link

aanand commented Jul 24, 2014

@scooterXL I've documented it and everything 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants