Epic: "compose run" should support every "docker run" option

[bfirsh]

fig run should support every option of docker run, just referring to a service instead of an image.

Usage: docker run [OPTIONS] IMAGE [COMMAND] [ARG...]

Run a command in a new container

  -a, --attach=[]            Attach to stdin, stdout or stderr.
  -c, --cpu-shares=0         CPU shares (relative weight)
  --cidfile=""               Write the container ID to the file
  --cpuset=""                CPUs in which to allow execution (0-3, 0,1)
  -d, --detach=false         Detached mode: Run container in the background, print new container id
  --dns=[]                   Set custom dns servers
  --dns-search=[]            Set custom dns search domains
  -e, --env=[]               Set environment variables
  --entrypoint=""            Overwrite the default entrypoint of the image
  --env-file=[]              Read in a line delimited file of ENV variables
  --expose=[]                Expose a port from the container without publishing it to your host
  -h, --hostname=""          Container host name
  -i, --interactive=false    Keep stdin open even if not attached
  --link=[]                  Add link to another container (name:alias)
  --lxc-conf=[]              (lxc exec-driver only) Add custom lxc options --lxc-conf="lxc.cgroup.cpuset.cpus = 0,1"
  -m, --memory=""            Memory limit (format: <number><optional unit>, where unit = b, k, m or g)
  --name=""                  Assign a name to the container
  --net="bridge"             Set the Network mode for the container
                               'bridge': creates a new network stack for the container on the docker bridge
                               'none': no networking for this container
                               'container:<name|id>': reuses another container network stack
                               'host': use the host network stack inside the container.  Note: the host mode gives the container full access to local system services such as D-bus and is therefore considered insecure.
  -P, --publish-all=false    Publish all exposed ports to the host interfaces
  -p, --publish=[]           Publish a container's port to the host
                               format: ip:hostPort:containerPort | ip::containerPort | hostPort:containerPort
                               (use 'docker port' to see the actual mapping)
  --privileged=false         Give extended privileges to this container
  --rm=false                 Automatically remove the container when it exits (incompatible with -d)
  --sig-proxy=true           Proxify received signals to the process (even in non-tty mode). SIGCHLD is not proxied.
  -t, --tty=false            Allocate a pseudo-tty
  -u, --user=""              Username or UID
  -v, --volume=[]            Bind mount a volume (e.g., from the host: -v /host:/container, from docker: -v /container)
  --volumes-from=[]          Mount volumes from the specified container(s)
  -w, --workdir=""           Working directory inside the container

Todo (in rough priority order)

• -u Provide user override option on command line #971
• --entrypoint Add support for entrypoint to "fig run" #511
• -w Adds -w WORKDIR option to fig run. #332
• -p Support mapping specific ports in "docker-compose run" #1709
• -v
• --cpuset
• --memory
• --env-file
• --net
• --memory-swappiness support --memory-swappiness #2383
• --volumes-from "docker-compose run" should support --volumes-from #1769

[thaJeztah]

👍

[ryansch]

👍

[zazabe]

👍

[gpmidi]

[d11wtq]

Agree in principle, but since we're already using the -T short flag, we need to hope docker never adds that. Likewise, if you give a name to --link that is not in the fig,yml, should it use it? If it is in the fig.yml, should it assume it needs to be converted to the actual service name? (i.e. It may actually be intended an external container that happens to be called 'db' without any prefix/suffix).

[dnephin]

A common pattern for this kind of thing is to support passing args after a -- (I'm not sure how docopt supports this, but hopefully it does).

So fig --verbose run console /bin/bash -- -c 3 -e foo=bar

Would pass -c and -e along to the docker command.

This is nice because

1. You don't have to worry about handling anything in fig, just pass everything along
2. You can continue to support extra arguments to fig run without ever worrying about conflicting with future docker args

[d11wtq]

This is nice because

1. You don't have to worry about handling anything in fig, just pass everything along
2. You can continue to support extra arguments to fig run without ever worrying about conflicting with future docker args

Actually, since we don't shell out to the docker client and talk to the API, this won't hold true unfortunately.

[dnephin]

Fair enough, you still have to do some translation to the docker-py args, but from what I've seen they seem to be pretty similar. docker-py may not support every argument yet either.

[Micka33]

To be more specific I think fig.yml should support all these options.

Especially since I need --cpuset and --memory

[danielkummer]

👍 We also need this, especially to pass environment variables to the docker run command!