-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Provide user override option on command line #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@aanand Any chance of getting this merged in? |
|
I'm looking for this feature at the moment as well |
|
Needs rebasing - will check again after that. |
|
@IanVS can you rebase? |
|
I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight. |
|
Nuking a PR for this reason is itself a newbie git mistake :)
Use the force (push), Luke!
|
|
@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it. |
|
The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/ Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume. I think the following should work. I'm assuming you haven't yet added Then, once the PR is done, you'll want to reset your You can leave out the |
|
@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already. |
|
💪😣 |
|
@aanand Build / Tests are passing and this is fully rebased, anything else I need to do? |
|
LGTM |
Provide user override option on command line
Provide user override option on command line Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Allow overriding a user on the command line from the one specified in
the docker-compose.yml
Based on commit f2f01e2 by @chmouel
See: #737
Signed-off-by: Ian VanSchooten ian@badgelabsllc.com