Skip to content

Conversation

@IanVS
Copy link

@IanVS IanVS commented Feb 15, 2015

Allow overriding a user on the command line from the one specified in
the docker-compose.yml

Based on commit f2f01e2 by @chmouel
See: #737

Signed-off-by: Ian VanSchooten ian@badgelabsllc.com

@Globegitter
Copy link

@aanand Any chance of getting this merged in?

@so0k
Copy link

so0k commented Mar 4, 2015

I'm looking for this feature at the moment as well

@aanand
Copy link

aanand commented Mar 4, 2015

Needs rebasing - will check again after that.

@Globegitter
Copy link

@IanVS can you rebase?

@IanVS
Copy link
Author

IanVS commented Mar 4, 2015

I made some newbie git mistakes here, so I'm going to have to nuke this PR and make a new one. Should have a chance tonight.

@md5
Copy link

md5 commented Mar 4, 2015 via email

@IanVS
Copy link
Author

IanVS commented Mar 4, 2015

@md5 I am doubly a newbie, then. I did my changes on master in my repo. I've not done a rebase before, but from what I can tell I need to have the changes in a feature branch. If you can explain what I should do or send me to a good resource so I can learn it, I'd really appreciate it.

@md5
Copy link

md5 commented Mar 4, 2015

The Github docs on rebasing are pretty good: https://help.github.com/articles/using-git-rebase/

Using a feature branch would have been nice, but changing branch names would require a new PR, which isn't necessary or useful in this case. The branch names you use in your repo only affect you, since nobody else is using it directly I'd assume.

I think the following should work. I'm assuming you haven't yet added docker/compose as an upstream; if you have added it, ignore that part and use the name of your corresponding remote if it isn't upstream:

git remote add upstream git@github.com:docker/compose.git
git fetch upstream
git checkout master
git rebase upstream/master
# Fix conflicts as needed
git push -f origin master

Then, once the PR is done, you'll want to reset your master back to be the same as upstream/master

git checkout master
git reset --hard upstream/master
git push -f origin master
git branch --set-upstream-to=upstream/master

You can leave out the --set-upstream-to command, but it's something I do to avoid inadvertently doing a git pull from the wrong remote into my master. I also do git config --global pull.ff only, so that git pull will never do a merge and I have to git merge non-fast-forward merges explicitly.

@IanVS
Copy link
Author

IanVS commented Mar 4, 2015

@md5 Thanks for taking the time to write out step-by-step instructions as well as the awesome tips (which I will definitely be using). That's just what I needed. I can feel my git-muscles strengthening already.

@md5
Copy link

md5 commented Mar 4, 2015

💪😣

@IanVS
Copy link
Author

IanVS commented Mar 4, 2015

@aanand I've rebased following instructions from @md5, hopefully it is ready for merge now?

Allows overriding a user on the command line from the one specified in
the docker-compose.yml

The added tests verify that a specified user overrides a default
user in the docker-compose.yml file.

Based on commit f2f01e2 by @chmouel

Signed-off-by: Ian VanSchooten <ian@badgelabsllc.com>
@IanVS
Copy link
Author

IanVS commented Mar 11, 2015

@aanand Build / Tests are passing and this is fully rebased, anything else I need to do?

@bfirsh
Copy link

bfirsh commented Mar 11, 2015

@bfirsh
Copy link

bfirsh commented Mar 11, 2015

cc @aanand @dnephin

@dnephin
Copy link

dnephin commented Mar 11, 2015

LGTM

dnephin added a commit that referenced this pull request Mar 11, 2015
Provide user override option on command line
@dnephin dnephin merged commit c23189a into docker:master Mar 11, 2015
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Provide user override option on command line
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants