Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
/docs/_site
/venv
fig.spec
*.sw[op]
15 changes: 9 additions & 6 deletions fig/cli/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,12 +221,11 @@ def run(self, project, options):
Usage: run [options] SERVICE [COMMAND] [ARGS...]

Options:
-d Detached mode: Run container in the background, print
new container name.
-T Disable pseudo-tty allocation. By default `fig run`
allocates a TTY.
--rm Remove container after run. Ignored in detached mode.
--no-deps Don't start linked services.
-d Detached mode: Run container in the background, print new container name.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentionally 80 chars wide!

-T Disable pseudo-tty allocation. By default `fig run` allocates a TTY.
--rm Remove container after run. Ignored in detached mode.
--no-deps Don't start linked services.
--entrypoint=<cmd> Override entrypoint of the image.
"""
service = project.get_service(options['SERVICE'])

Expand Down Expand Up @@ -254,6 +253,10 @@ def run(self, project, options):
'tty': tty,
'stdin_open': not options['-d'],
}

if options['--entrypoint']:
container_options['entrypoint'] = options.get('--entrypoint')

container = service.create_container(one_off=True, **container_options)
if options['-d']:
service.start_container(container, ports=None, one_off=True)
Expand Down
8 changes: 6 additions & 2 deletions fig/container.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,12 @@ def human_readable_state(self):
@property
def human_readable_command(self):
self.inspect_if_not_inspected()
if self.dictionary['Config']['Cmd']:
return ' '.join(self.dictionary['Config']['Cmd'])
config = self.dictionary['Config']
entrypoint = config['Entrypoint'] or []
cmd = config['Cmd'] or []
whole_cmd = entrypoint + cmd
if whole_cmd:
return ' '.join(whole_cmd)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnephin Thanks for replying. Isn't this a function that return some information about an already running container? What do you mean by "this"?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes

else:
return ''

Expand Down
2 changes: 2 additions & 0 deletions tests/fixtures/dockerfile_with_entrypoint/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
FROM busybox:latest
ENTRYPOINT echo "From prebuilt entrypoint"
2 changes: 2 additions & 0 deletions tests/fixtures/dockerfile_with_entrypoint/fig.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
service:
build: tests/fixtures/dockerfile_with_entrypoint
15 changes: 15 additions & 0 deletions tests/integration/cli_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,21 @@ def test_run_without_command(self, __):
[u'/bin/true'],
)

@patch('dockerpty.start')
def test_run_service_with_entrypoint_overridden(self, _):
self.command.base_dir = 'tests/fixtures/dockerfile_with_entrypoint'
name = 'service'
self.command.dispatch(
['run', '--entrypoint', '/bin/echo', name, 'helloworld'],
None
)
service = self.project.get_service(name)
container = service.containers(stopped=True, one_off=True)[0]
self.assertEqual(
container.human_readable_command,
u'/bin/echo helloworld'
)

def test_rm(self):
service = self.project.get_service('simple')
service.create_container()
Expand Down