Add support for the --entrypoint option of docker run #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this already supported in fig.yml with 'entrypoint' key? Does this PR intend to make this available on fig CLI? |
Author
|
@salehe Yes, since some images have specified ENTRYPOINT in their Dockerfiles, we cannot always override the command using CMD only. |
|
This is related to #363 |
Author
There was a problem hiding this comment.
@dnephin Thanks for replying. Isn't this a function that return some information about an already running container? What do you mean by "this"?
Signed-off-by: Satoru Logic <satorulogic@gmail.com>
Author
|
@salehe Are you a core developer of fig? |
|
No! I'm just a contributer @suzaku |
|
+1 |
|
Replaced by #511 |
xulike666
pushed a commit
to xulike666/compose
that referenced
this pull request
Jan 19, 2017
snapshot: Fix leaked mounts and temp directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
commandinfig.ymlto override the default command, but this won't work if the docker image we are working with specifies aENTRYPOINTfor its containers.In my case, the Dockerfile of the main service has specified something like
["gunicorn", "-c", "config.py"]as itsENTRYPOINT, so I can't do things likepython manage.py syncdbif I can't override theENTRYPOINT.Entrypoints can be overrdden by the
--entrypointoption, this PR attempts to solve the problem by exposing this option infig.