-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add completion command and fix convert #9269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f98c167 to
694c6b5
Compare
bc0cb8c to
593d252
Compare
milas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can't wait to get it connected to the docker CLI 🎉
|
Ah project name completion isn't working, it looks like the I'm getting |
|
Oh, we lazily initialize the Lines 41 to 44 in db88241
|
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Co-authored-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
593d252 to
5327c40
Compare
|
@milas Good catch! |
milas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Project name completion looks good now. Can't wait 🥳
|
Should this close #8550 as well? |
What I did
Add completion command and fix convert
To test, you can trigger the completions with the following example:
compose.yamlThis should print the 3 services as proposals
This should propose the 2 services starting with the letter "b"
For now, the
Docker CLIis not triggering compose's completion yet. That should be done in a following PR.