Add support for command line completion by docker/cli #9462
Conversation
ndeloof
force-pushed
the
cobra_completion_v2
branch
3 times, most recently
from
721360b to
f5201c3
Compare
(see docker/cli#3429) Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
cobra_completion_v2
branch
from
f5201c3 to
8d968c3
Compare
|
|
||
| replace ( | ||
| github.com/docker/cli => github.com/docker/cli v20.10.3-0.20220309205733-2b52f62e9627+incompatible | ||
| github.com/docker/cli => github.com/ndeloof/cli v0.0.0-20220317134108-66942b8c2379 |
There was a problem hiding this comment.
Hmmm... This if I understood well is related to manager.Metadata#Completion. The thing is that this is not merged in docker/cli yet...
I'm also not sure if the SchemaVersion should change too.
There was a problem hiding this comment.
Also... If we are already changing the struct, that would be great if we could add a Meta: map[string]string to open for other applications.
There was a problem hiding this comment.
this one is actually obsolete, in docker/cli we gave up with a new schema, and just run the __complete command on plugins. If they don't implement this command, it will just fail and offer no completion.
Also, the idea of SchemaVersion is to avoid an open map[string]string that would make it unpredictable about the possible values being set by plugin.
|
@ndeloof Since the |
|
Am I correct that only required thing remained is this one MR for completion to be working? |
Co-authored-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
|
Closing this PR in favor of #9269 that includes the changes of this one |
Co-authored-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Co-authored-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Co-authored-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Integrates PR #9462 with additional fixes/changes. Additional changes will be required to utilize this. Co-authored-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
3 participants
(see docker/cli#3429)
What I did
Added command line completion support
Related issue
closes #8550
(not mandatory) A picture of a cute animal, if possible in relation with what you did
